fix(mail): resolve theme before first paint on pre-login screens - #387
Open
krantheman wants to merge 1 commit into
Open
fix(mail): resolve theme before first paint on pre-login screens#387krantheman wants to merge 1 commit into
krantheman wants to merge 1 commit into
Conversation
The server renders <html data-theme> from User.desk_theme, which is only known for an authenticated session — Guests always get 'light', so the login/signup/reset screens flashed white on a dark machine before mail's own preference (User Settings.color_scheme) arrived with its boot data. Resolve the theme in a blocking script in <head>, from the last mode applied on this device (localStorage) falling back to prefers-color-scheme for guests, and let the fetched color scheme take over once it lands. Other apps keep the server-rendered desk theme untouched. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<html data-theme>is rendered fromUser.desk_theme, which the server only knows for an authenticated session — Guests always getlight, so the login/signup/reset screens flashed white on a dark machine.A blocking script in
<head>now resolves the theme from the last mode applied on this device (localStorage), falling back toprefers-color-schemefor guests; the fetchedcolor_schemetakes over once boot data lands. Other apps keep the server-rendered desk theme untouched.Closes #1