fix(writer): keep list numbering continuous, plus assorted drive/writer fixes - #378
Open
safwansamsudeen wants to merge 2 commits into
Open
fix(writer): keep list numbering continuous, plus assorted drive/writer fixes#378safwansamsudeen wants to merge 2 commits into
safwansamsudeen wants to merge 2 commits into
Conversation
Collaborator
Author
|
Also redoes list view, adds infinite scrolling, removes rename dialog, and a couple more long pending issues. |
…er fixes fix(writer): join adjacent same-type list nodes after each transaction so deleting a block between two lists (or Enter-lifting an item out) no longer restarts numbering; map boundaries through tr.mapping, require matching list types, and collect top-level boundaries since descendants() skips the doc node fix(drive): let an open dialog's own Escape handler run instead of clearing the selection in GridView/ListView (preventDefault was blocking Reka's dismiss) fix(writer): focus the comment editor without scrolling, on mount and when it flips into edit mode refactor(drive): use the Button component for UploadTracker controls and MoveDialog breadcrumbs; tidy ConfirmDialog markup and use a solid trash button refactor(writer): drop the watermark logic from PDF and print export style(writer): sentence-case the settings labels style(drive): add gap in the UserListSettings avatar row Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
… typography Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
safwansamsudeen
force-pushed
the
fix/frappe-ui-typography
branch
from
July 29, 2026 09:09
fd60996 to
c4d46ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Primary fix: list numbering in the Writer editor no longer resets when you edit around a list. Deleting a block between two lists — or pressing Enter to lift an item out — used to leave two sibling
orderedListnodes, so the second one restarted at 1. A newJoinAdjacentListsProseMirror extension merges adjacent same-type list nodes back into one after each transaction.Bundled alongside are several small drive/writer fixes that were in the working tree.
Changes
JoinAdjacentListsextension — maps boundaries throughtr.mapping(avoids the stale-positionCannot join paragraph onto orderedListthrow), requires both siblings to be the same list type, and collects top-level boundaries sincedescendants()skips the doc node. Wired intoCoreEditor'seditorExtensions.GridView/ListView(preventDefaultwas blocking Reka's dismiss).Buttoncomponent forUploadTrackercontrols andMoveDialogbreadcrumbs; tidyConfirmDialogmarkup, solid trash button.UserListSettingsavatar row.Testing
The list-join logic was verified against a ProseMirror repro covering top-level splits, paragraph-separated lists, mixed list types, the Enter-out case, nested + top-level adjacency (the stale-position crash), and triple-adjacent lists — all merge correctly with no throws.
🤖 Generated with Claude Code