Skip to content

test: add e2e tests for drive and writer - #345

Open
BreadGenie wants to merge 28 commits into
frappe:developfrom
BreadGenie:test/drive-writer-e2e
Open

test: add e2e tests for drive and writer#345
BreadGenie wants to merge 28 commits into
frappe:developfrom
BreadGenie:test/drive-writer-e2e

Conversation

@BreadGenie

Copy link
Copy Markdown
Member

also move meet e2e to the same dir

@greptile-apps

greptile-apps Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

Safe to merge; the backend cleanup and _not_in_disk fix are correct, and the E2E infrastructure is well-structured.

All changes are additive test infrastructure plus targeted backend fixes. The only gap found is an incomplete assertion in the restore test path.

Files Needing Attention: e2e/drive-backed-apps/specs/drive/drive.spec.ts — restore assertion doesn't verify the entity reappears in the main drive view.

Reviews (19): Last reviewed commit: "Merge upstream/develop into test/drive-w..." | Re-trigger Greptile

Comment thread suite/drive/e2e_api.py Outdated
Comment thread e2e/drive-backed-apps/global-setup.ts
BreadGenie and others added 3 commits July 24, 2026 15:12
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@BreadGenie
BreadGenie force-pushed the test/drive-writer-e2e branch from b4a3a63 to f720c60 Compare July 24, 2026 12:18
Comment thread e2e/drive-backed-apps/global-teardown.ts
Comment thread e2e/drive-backed-apps/global-setup.ts
@BreadGenie
BreadGenie requested a review from krantheman as a code owner July 28, 2026 07:20
@BreadGenie
BreadGenie requested a review from s-aga-r as a code owner July 28, 2026 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants