Improve exception handling of Unicommerce#430
Closed
manish-girman wants to merge 1 commit into
Closed
Conversation
fix(inventory): Add logging and error handling to inventory sync - Add integration log creation with detailed progress tracking - Add per-warehouse error handling (continue on failure) - Add summary report with success/failure counts - Fix silent failures - all operations now logged - No breaking changes, maintains original controller imports fix(product): Fix critical item sync bug affecting 30% of inventory fix(product): Fix critical item sync bug affecting 30% of inventory Critical Fix: - Changed SQL query: SELECT item.name instead of item.item_code - Fixed JOIN: ON item.name instead of item.item_code - Bug caused 1,653 items to fail (frappe.get_doc needs primary key) - Items where name ≠ item_code crashed silently Improvements: - Add per-item error handling (batch continues on failures) - Add [x/total] progress tracking in logs - Add detailed error messages and summary reports - Add inline documentation explaining the bug fix Impact: 5,522/5,522 items can now sync (was 3,869/5,522) Update product.py Update inventory.py Update inventory.py fix: Update inventory.py with proper import Update invoice.py fix: Update invoice.py fix: Update invoice.py 2.0 fix : Update invoice.py 3.0, patch work added fix: Update invoice.py 4.0 fix: Update order.py, added logs, error handling Update order.py Update invoice.py fix(unicommerce-invoice): apply item tax templates and dynamic GST template resolution fix: commented doc_events part from hooks.py Update invoice.py Update invoice.py Better exception handling for unicommerce
manish-girman
force-pushed
the
improve-exception-handling
branch
from
05f4b5b to
c2940b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.