Add bounded HTJ2K candidate rate control - #79
Merged
Conversation
Generate exact cleanup and refinement candidates across native, Metal, and CUDA paths; select them with tile-aware rate control; add external parity tooling, batch benchmarks, and regression coverage.
Emit each selected cleanup and refinement set in one quality-layer contribution so external decoders retain the exact cleanup boundary while block-level allocation still spans layer budgets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
cargo test -p j2k-types -p j2k-native -p j2k -p j2k-metalcargo test -p j2k-comparecargo test -p j2k-cuda-j2k-engine --all-featurescargo test -p j2k-cuda --all-features --no-fail-fastpython3 -m unittest discover -s scripts/tests -p test_open*j2k_reference.pycargo fmt --all -- --checkcargo xtask repo-lintwith 101 passing policy testsgit diff --checkand staged diff validationPerformance evidence
For verified resident 512 x 512 batches on the Apple Metal host, Metal beat parallel CPU packetization by 1.52x at batch 1, 1.94x at batch 4, and 2.99x at batch 16. The single-tile end-to-end lossy candidate path remains 2.65x to 2.81x slower than CPU, so this change makes no blanket Metal speed claim.
Known limits