Stage strict 0.8 API and release contracts - #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0xFFemits the required stuffed zero byteWhy
The repository had accumulated policy tied to file shape and implementation layout while several user-visible contracts remained implicit. This made maintenance changes disproportionately large and allowed the easiest decode path to select lenient behavior.
The final Metal validation also exposed a separate correctness defect in selective arithmetic coding bypass: a raw Tier-1 segment could end immediately after
0xFF, leaving the mandatory stuffed zero bit absent. Strict decoding correctly rejected that codestream.Impact
0xFFboundaryThe intentional 0.7-to-0.8 source breaks and the next 0.8.x baseline are recorded in the checked-in API review artifacts.
Validation
cargo xtask cicargo xtask release-metal --mode fullcargo xtask packagecargo xtask stable-apicargo xtask semvercargo xtask release-integritycargo xtask codec-math-codegencargo xtask public-support --finalpython3 -m unittest discover -s scripts/tests -p 'test_*.py'— 69 passed0xFFregressionsExact-SHA evidence
Candidate SHA:
340afad9537dfbb91c30780f921c88201464bdf3