The Surface Language #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forell
approved these changes
May 29, 2025
Comment on lines
+63
to
+64
| | NPName of { ~pos : Position }, T | ||
| | NPSel of { ~pos : Position }, Path ModuleName, T |
There was a problem hiding this comment.
FYI the prefix "NP" originally stood for "Namespace Path", dating back to when modules were briefly called namespaces. Maybe it's time to update it to something more informative, like "MP".
| {## Named parameter of the type scheme. ##} | ||
| pub data SchemeArg = | ||
| {## Type parameter. ##} | ||
| | SA_Type of { ~pos : Position }, TName, TVar, KindExpr |
There was a problem hiding this comment.
So, what are the conventions for multicharacter prefixes in constructors? TName gets TN with no underscore, this gets SA_, and there are both variants elsewhere too. I don't really have a preference myself.
| end | ||
|
|
||
| {## File. ##} | ||
| pub data File = |
There was a problem hiding this comment.
Should a File have a ~pos for the purpose of retrieving the filename easily, or is that unlikely to be useful?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces definition of the Surface language. REPL related parts are not implemented.
The code uses type synonyms, that are not merged into master branch of DBL, yet.