Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong DNS query type in DANE lookups for IPv6-only hosts #632

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

cuihaoleo
Copy link
Contributor

An apparent typo. This should fix #631.

The patch is tested on top of v0.7.

@codecov-commenter
Copy link

Codecov Report

Merging #632 (5d8f09e) into master (d9920f0) will increase coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #632      +/-   ##
==========================================
+ Coverage   52.39%   52.42%   +0.03%     
==========================================
  Files         128      128              
  Lines       13287    13287              
==========================================
+ Hits         6962     6966       +4     
+ Misses       5669     5666       -3     
+ Partials      656      655       -1     
Flag Coverage Δ
integration 34.03% <ø> (ø)
unit 53.84% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
framework/dns/dnssec.go 28.07% <0.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@foxcpp foxcpp merged commit 5724788 into foxcpp:master Oct 12, 2023
4 of 5 checks passed
@foxcpp
Copy link
Owner

foxcpp commented Oct 12, 2023

Thanks!

@cuihaoleo cuihaoleo deleted the fix-dane-wrong-query branch October 12, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No usable MXs when sending to IPv6-only domain
3 participants