Skip to content

Fix top call resources #3426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix top call resources #3426

wants to merge 1 commit into from
+1 −1

Conversation

piotmag769
Copy link
Member

@piotmag769 piotmag769 commented May 29, 2025 •
edited
Loading

Partially solves #3413 (to be verified by someone from snforge team)

Introduced changes

  • stop adding resources used by nested calls to top call recursively - they already contain cumulative resources

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests - I believe there is a task for that
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@piotmag769 piotmag769 requested a review from a team as a code owner May 29, 2025 18:04
@franciszekjob franciszekjob requested a review from cptartur May 30, 2025 08:51
cptartur
cptartur requested changes May 30, 2025
View reviewed changes
Copy link
Member

@cptartur cptartur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably a good solution, but let's investigate these problems internally before we start merging fixes

ddoktorski
ddoktorski approved these changes Jun 2, 2025
View reviewed changes
Copy link
Contributor

@ddoktorski ddoktorski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't be the same logic for sierra gas in the add_sierra_gas_resources function?

@piotmag769
Copy link
Member Author

Shouldn't be the same logic for sierra gas in the add_sierra_gas_resources function?

Did not check it, but yes xD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cptartur cptartur cptartur requested changes

@ddoktorski ddoktorski ddoktorski approved these changes

@franciszekjob franciszekjob franciszekjob approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@piotmag769 @ddoktorski @cptartur @franciszekjob