-
Notifications
You must be signed in to change notification settings - Fork 2k
feat: route all prints through common::shell
#6569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey @DaniPopes, beyond the large diff + conflicts are there any blockers for this PR? |
yes #8389 |
Will be picking this up now that #8389 has been merged, should be unblocked Going to split it into multiple per-crate PRs, starting with the macros |
Yeah most of the changes are |
Closing in favor of #8954 |
Rebase of #5746 plus moving from fork to this repo.
Original:
Motivation
Fixes #3981.
Fixes #2433.
Fixes #1976.
Fixes #7055.
Likely fixes #8568
Implementation from
cargo
, tweaked so it can be a global static instead of a field in aConfig
struct.Solution
Disallow
std::print!
and similar by replacing them withShell
macros.