Skip to content

feat: route all prints through common::shell #6569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 24 commits into from
Closed

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Dec 11, 2023

Rebase of #5746 plus moving from fork to this repo.

Original:


Motivation

Fixes #3981.
Fixes #2433.
Fixes #1976.
Fixes #7055.
Likely fixes #8568

Implementation from cargo, tweaked so it can be a global static instead of a field in a Config struct.

Solution

Disallow std::print! and similar by replacing them with Shell macros.

@DaniPopes DaniPopes marked this pull request as draft December 11, 2023 15:23
@zerosnacks
Copy link
Member

Hey @DaniPopes, beyond the large diff + conflicts are there any blockers for this PR?

@DaniPopes
Copy link
Member Author

yes #8389

@zerosnacks
Copy link
Member

zerosnacks commented Sep 3, 2024

Will be picking this up now that #8389 has been merged, should be unblocked

Going to split it into multiple per-crate PRs, starting with the macros

@DaniPopes
Copy link
Member Author

Yeah most of the changes are struct ShellOptions, common::io and the rest is search and replace. the project compiler stuff should be superseded by other work

@zerosnacks zerosnacks removed the T-blocked Type: blocked label Sep 5, 2024
@zerosnacks
Copy link
Member

Closing in favor of #8954

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-internals Area: internals
Projects
None yet
2 participants