Skip to content

Conversation

0xtutankhamun
Copy link

Motivation

The sol_macro_gen.rs file had two instances where fs::create_dir_all() results were being ignored using let _ =, which could silently hide directory creation failures during binding generation.

Solution

Replaced ignored fs::create_dir_all() calls with proper error handling using the ? operator in write_to_crate() and write_to_module() methods.

This ensures directory creation failures are properly reported instead of being silently ignored.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@onbjerg onbjerg closed this Oct 14, 2025
@github-project-automation github-project-automation bot moved this to Done in Foundry Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants