fix: handle create_dir_all errors in sol macro generation #12079
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
sol_macro_gen.rs
file had two instances wherefs::create_dir_all()
results were being ignored usinglet _ =
, which could silently hide directory creation failures during binding generation.Solution
Replaced ignored
fs::create_dir_all()
calls with proper error handling using the?
operator inwrite_to_crate()
andwrite_to_module()
methods.This ensures directory creation failures are properly reported instead of being silently ignored.
PR Checklist