bump: alloy + revm + alloy-evm #10454
Draft
+1,321
−763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apply patches for block-explorers and compilers
Use ChaChaRng as temporary measure since proptest is on rand 8
This was referenced May 7, 2025
yash-atreya
commented
May 7, 2025
Comment on lines
+1160
to
+1165
| // Prop test uses rand 8 whereas alloy-core has been bumped to rand 9 | ||
| // self.test_runner().rng() | ||
| self.rng.get_or_insert_with(|| match self.config.seed { | ||
| Some(seed) => ChaChaRng::from_seed(seed.to_be_bytes::<32>()), | ||
| None => ChaChaRng::from_os_rng(), | ||
| }) |
There was a problem hiding this comment.
Adds a temp rng field to Cheatcodes to generate random values with the given seed
This is a workaround as proptest still uses rand 8.
26 tasks
mattsse
pushed a commit
to foundry-rs/compilers
that referenced
this pull request
May 7, 2025
mattsse
pushed a commit
to foundry-rs/block-explorers
that referenced
this pull request
May 7, 2025
|
lgtm! RE: rand 8 / rand 9
if we highlight this in the changelog this is fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Builds on #10183
Bumps
Unblocks #10411
Solution
Uses the following patches:
block-explorers - foundry-rs/block-explorers#86
compilers - foundry-rs/compilers#263
fork-db - foundry-rs/foundry-fork-db#46
PR Checklist