-
Notifications
You must be signed in to change notification settings - Fork 2k
feat: Etherscan V2 support #10440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: Etherscan V2 support #10440
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
97e23a6
Adding support to etherscanv2
iainnash a98d6d0
clippy+fmt
iainnash 395712a
Adding default for v2 and updating configuration to parse etherscan a…
iainnash 5866805
Updating api_version to use new variable and fix merge
iainnash 735212e
Use block explorer rev, fix fmt
grandizzy e2f4f11
fix api version parsing
iainnash 3d60de4
fix fmt
iainnash 5580f96
Merge branch 'master' into adding_support_etherscan_v2
iainnash 08f6305
Merge branch 'master' into adding_support_etherscan_v2
grandizzy 3f82c09
Simplify Etherscan provider option, default v2
grandizzy 735424c
Merge branch 'master' into etherscan-v2-redo
grandizzy d8b07a6
Use released version
grandizzy b9f0864
Updates, fix script --verify
grandizzy 6ffa6e1
Merge branch 'master' into etherscan-v2-redo
grandizzy 2dfa7c0
Clone api version, cast
grandizzy 622aed4
Cast fixes
grandizzy a182e56
Tests nits
grandizzy 6685dca
configs for verify check
grandizzy 3a338c3
Merge branch 'master' into etherscan-v2-redo
grandizzy 24782b1
Simplify, use EtherscanApiVersion enum
grandizzy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -50,12 +50,10 @@ impl CreationCodeArgs { | |
|
||
let config = rpc.load_config()?; | ||
let provider = utils::get_provider(&config)?; | ||
let api_key = etherscan.key().unwrap_or_default(); | ||
let chain = provider.get_chain_id().await?; | ||
etherscan.chain = Some(chain.into()); | ||
let client = Client::new(chain.into(), api_key)?; | ||
|
||
let bytecode = fetch_creation_code(contract, client, provider).await?; | ||
let bytecode = fetch_creation_code_from_etherscan(contract, ðerscan, provider).await?; | ||
|
||
let bytecode = parse_code_output( | ||
bytecode, | ||
|
@@ -131,11 +129,16 @@ pub async fn parse_code_output( | |
} | ||
|
||
/// Fetches the creation code of a contract from Etherscan and RPC. | ||
pub async fn fetch_creation_code( | ||
pub async fn fetch_creation_code_from_etherscan( | ||
contract: Address, | ||
client: Client, | ||
etherscan: &EtherscanOpts, | ||
provider: RetryProvider, | ||
) -> Result<Bytes> { | ||
let config = etherscan.load_config()?; | ||
let chain = config.chain.unwrap_or_default(); | ||
let api_version = config.get_etherscan_api_version(Some(chain)); | ||
let api_key = config.get_etherscan_api_key(Some(chain)).unwrap_or_default(); | ||
Comment on lines
+138
to
+140
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it's funny how when you try to unify things you now suddenly need to handle another case -.- |
||
let client = Client::new_with_api_version(chain, api_key, api_version)?; | ||
let creation_data = client.contract_creation_data(contract).await?; | ||
let creation_tx_hash = creation_data.transaction_hash; | ||
let tx_data = provider.get_transaction_by_hash(creation_tx_hash).await?; | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unrelated, flaky immutable test