Skip to content

fix(forge): run git submodule sync when installing #10347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2025
Merged

fix(forge): run git submodule sync when installing #10347

merged 1 commit into from
Apr 22, 2025

Conversation

grandizzy
Copy link
Collaborator

Motivation

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@grandizzy grandizzy added T-bug Type: bug C-forge Command: forge labels Apr 22, 2025
@grandizzy grandizzy marked this pull request as ready for review April 22, 2025 11:42
zerosnacks
zerosnacks approved these changes Apr 22, 2025
View reviewed changes
Copy link
Member

@zerosnacks zerosnacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@grandizzy grandizzy merged commit 8690fef into foundry-rs:master Apr 22, 2025
22 checks passed
@github-project-automation github-project-automation bot moved this to Done in Foundry Apr 22, 2025
@grandizzy grandizzy deleted the issue-9611 branch April 22, 2025 12:23
@grandizzy grandizzy self-assigned this Apr 22, 2025
@grandizzy grandizzy moved this from Done to Completed in Foundry Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@zerosnacks zerosnacks zerosnacks approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

Assignees

@grandizzy grandizzy

Labels
C-forge Command: forge T-bug Type: bug
Projects
Foundry
Status: Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(forge): forge install should run git submodule sync
3 participants
@grandizzy @mattsse @zerosnacks