Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Bug At the footer #271

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Ranamalsingh12
Copy link

Issue

When i forked and clone the fossology UI and the backend on the home page there is nothing in front of the version, branch, commit it just was an empty array at first i thought this was a issue from the backend but when i had a chat with the people from backend they said that they are working on it but also the response will be the same for new user so i change the code and add a ternary operator and now you can know what will be in front of the version, branch and commit.

Please describe the changes in your pull request in few words here.

Changes

I add the change at footer. It works like when a new person first download the backend from the fossology and fossology UI. At home page at the footer there was a ui bug that there is nothing in front of version, Branch, commit i changed the code that for new person which will be having same response from backend fom footer as me i used if else condition (ternary operator) in react to solve that issue.

Please consider using the closing keyword if the pull request is proposed to
fix an issue already created in the repository
(https://help.github.com/articles/closing-issues-using-keywords/)

@dushimsam
Copy link
Contributor

could you squash those commits into one

@Ranamalsingh12
Copy link
Author

Sure @dushimsam i will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants