-
Notifications
You must be signed in to change notification settings - Fork 223
Release/4.0.0 #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/4.0.0 #244
Conversation
Reviewer's Guide by SourceryThis pull request introduces a new Updated class diagram for connection moduleclassDiagram
class ConnectionHandler {
+connect()
+disconnect()
+send(data)
+receive(length)
}
class SerialHandler {
+port: str
+baudrate: int
+connect()
+disconnect()
+send(data)
+receive(length)
}
class WLANHandler {
+host: str
+port: int
+connect()
+disconnect()
+send(data)
+receive(length)
}
ConnectionHandler <|-- SerialHandler
ConnectionHandler <|-- WLANHandler
note for ConnectionHandler "Base class for SerialHandler and WLANHandler"
note for SerialHandler "Handles serial communication"
note for WLANHandler "Handles WLAN communication"
Class diagram for ADCBufferMixin refactoringclassDiagram
class ADCBufferMixin {
+get_buffer_data()
+configure_buffer()
}
note for ADCBufferMixin "Moved to instrument.buffer module"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @bessman - I've reviewed your changes - here's some feedback:
Overall Comments:
- The changelog entries are well-formatted and informative.
- Consider adding a brief summary of the changes in the description of the pull request.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
This release introduces a new
connection
module to handle different control interfaces, including a newWLANHandler
for WLAN control. It also includes several breaking changes, such as moving and deprecating theserial_handler
, and a fix for SPI configuration.New Features:
connection
module for different control interfaces.WLANHandler
class for controlling the PSLab over WLAN.ConnectionHandler
base class forSerialHandler
andWLANHandler
.connection.autoconnect
function.instrument.buffer
module.Bug Fixes:
Enhancements:
serial_handler
in favor ofconnection
.SerialHandler
toconnection
.detect
toconnection
.check_serial_access_permission
private.ADCBufferMixin
toinstrument.buffer
.Chores: