Skip to content

fix: replace non-FLOSS library for 3rd party library screen #2645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

marcnause
Copy link
Contributor

@marcnause marcnause commented Mar 11, 2025

Fixes #2644

Changes

  • removed non-FLOSS library
  • added AboutLibraries
  • changed code to replace old 3rd party library screen with new version based on AboutLibraries
  • changed app theme since AboutLibraries requires a theme based on MaterialComponents (I have not noticed any side effects)

Screenshots / Recordings

Screen_recording_20250311_221433.mp4

Looks better than the old solution, doesn't it!?

Checklist:

  • No hard coding: I have used resources from strings.xml, dimens.xml and colors.xml without hard coding any value.
  • No end of file edits: No modifications done at end of resource files strings.xml, dimens.xml or colors.xml.
  • Code reformatting: I have reformatted code and fixed indentation in every file included in this pull request.
  • No extra space: My code does not contain any extra lines or extra spaces than the ones that are necessary.

Summary by Sourcery

Replaces the non-FLOSS library used for the 3rd party library screen with the AboutLibraries library. Updates the app theme to be based on MaterialComponents to be compatible with AboutLibraries.

Enhancements:

  • Replaces the 3rd party library screen with a new version based on AboutLibraries.
  • Updates the app theme to be based on MaterialComponents to be compatible with AboutLibraries.
  • Removes the OssLicenseScreenTheme.

@marcnause marcnause added Dependencies Adding dependencies and libraries Fix Solution to an existing issue in app labels Mar 11, 2025
Copy link

sourcery-ai bot commented Mar 11, 2025

Reviewer's Guide by Sourcery

This pull request replaces the Google OSS Licenses library with the AboutLibraries library to address a non-FLOSS issue. The application theme was updated to be compatible with AboutLibraries, and a description was added to the AboutLibraries screen.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Replaced the Google OSS Licenses library with the AboutLibraries library to address the non-FLOSS issue.
  • Removed the Google OSS Licenses plugin.
  • Added the AboutLibraries plugin.
  • Added the AboutLibraries dependency.
  • Removed the Google OSS Licenses dependency.
  • Replaced the original third-party license screen with a new screen based on AboutLibraries.
app/build.gradle.kts
build.gradle.kts
app/src/main/java/io/pslab/activity/MainActivity.java
app/src/debug/AndroidManifest.xml
app/src/main/AndroidManifest.xml
Updated the application theme to be compatible with the new AboutLibraries library.
  • Changed the parent theme of AppTheme to Theme.MaterialComponents.Light.DarkActionBar.Bridge.
  • Removed the OssLicenseScreenTheme style.
app/src/main/res/values/styles.xml
app/src/main/res/values-v21/styles.xml
Added a description for the AboutLibraries screen.
  • Added strings to describe the AboutLibraries screen.
app/src/main/res/values/strings.xml

Assessment against linked issues

Issue Objective Addressed Explanation
#2644 Replace the non-FOSS library used for the 3rd party library screen with a FOSS alternative.

Possibly linked issues

  • F-Droid build failed #2644: The PR addresses the issue by replacing the non-FOSS library with AboutLibraries, resolving the F-Droid build failure.
  • F-Droid build failed #2644: The PR addresses the issue by replacing a non-FLOSS library with AboutLibraries, which displays open-source licenses.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @marcnause - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider mentioning the theme change in the PR title for better visibility.
  • It might be worth adding a comment explaining why the theme change doesn't have side effects.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

@marcnause marcnause enabled auto-merge (rebase) March 11, 2025 21:31
Copy link
Collaborator

@AsCress AsCress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcnause LGTM !

@marcnause marcnause merged commit 32f6f51 into fossasia:development Mar 13, 2025
5 checks passed
@marcnause marcnause deleted the fix/3rd-party-license-lib branch March 13, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Adding dependencies and libraries Fix Solution to an existing issue in app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

F-Droid build failed
2 participants