-
Notifications
You must be signed in to change notification settings - Fork 818
fix: replace non-FLOSS library for 3rd party library screen #2645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replace non-FLOSS library for 3rd party library screen #2645
Conversation
… FLOSS library fixes: fossasia#2644
Reviewer's Guide by SourceryThis pull request replaces the Google OSS Licenses library with the AboutLibraries library to address a non-FLOSS issue. The application theme was updated to be compatible with AboutLibraries, and a description was added to the AboutLibraries screen. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @marcnause - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider mentioning the theme change in the PR title for better visibility.
- It might be worth adding a comment explaining why the theme change doesn't have side effects.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Build successful. APKs to test: https://github.com/fossasia/pslab-android/actions/runs/13798542841/artifacts/2733450456 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcnause LGTM !
Fixes #2644
Changes
MaterialComponents
(I have not noticed any side effects)Screenshots / Recordings
Screen_recording_20250311_221433.mp4
Looks better than the old solution, doesn't it!?
Checklist:
strings.xml
,dimens.xml
andcolors.xml
without hard coding any value.strings.xml
,dimens.xml
orcolors.xml
.Summary by Sourcery
Replaces the non-FLOSS library used for the 3rd party library screen with the AboutLibraries library. Updates the app theme to be based on MaterialComponents to be compatible with AboutLibraries.
Enhancements: