-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snyk upgrade af258aceeda577e75b79cf91208c9ff2 #9197
base: master-backup
Are you sure you want to change the base?
Snyk upgrade af258aceeda577e75b79cf91208c9ff2 #9197
Conversation
Snyk has created this PR to upgrade @stripe/stripe-js from 1.22.0 to 1.25.0. See this package in npm: See this project in Snyk: https://app.snyk.io/org/savaliyabhargav/project/d89f4ad4-264c-47cc-af83-63b8ea97349c?utm_source=github&utm_medium=referral&page=upgrade-pr
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Reviewer's Guide by SourceryThis pull request upgrades the base Docker image for both the builder and production stages from Class diagram showing updated @stripe/stripe-js dependencyclassDiagram
class Stripe {
<<external>>
+version: string = "1.25.0"
}
note for Stripe "Upgraded from 1.22.0"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @savaliyabhargav - I've reviewed your changes - here's some feedback:
Overall Comments:
- It looks like this PR upgrades the base node image and the stripe-js dependency - can you add a description of why these changes are being made?
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Fixes #
Short description of what this resolves:
Changes proposed in this pull request:
Checklist
development
branch.Summary by Sourcery
Enhancements: