Skip to content

Fix: Extra DB migration file is created #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

hongquan
Copy link
Member

In additional to fix of "extra DB migration file keeps being created", this PR also does:

  • Use uv as Python package manager.
  • Use Ruff to format code.
  • Make PostgreSQL the only supported DB.

Because later on we will need ArraryField, UUIDField, which are only available on PostgreSQL.
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @hongquan, your pull request is too large to review

@norbusan
Copy link
Member

Hi @hong_quan Nice idea, but could you please split this into two steps:

  • first step does the real code changes (switch to uv, ...)
  • second one does the ruff-part
    With the current PR it is impossible to see the actual code changes to switch to ruff/uv are in the middle of all the ruffification.

Aalso, concerning the postgres only change: Please adjust the README.rst to contain a short info/explanation that when running it locally on hte live system (no docker) than one needs to provide a postgres server and set env variables.

Also, the entry DATABASE could be removed from the env.*.sample, and the code in the entrypoint scripts can be simplified to always run the postgres code since it checls for $DATABASE.

So probably the postgres should be a separate PR, too, to be able to be reviewed.

@hongquan
Copy link
Member Author

Close to rework (split to two smaller PRs).

@hongquan hongquan closed this Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants