Skip to content

Performance: getTraefikConfig anySitesOnline out of loop / isDomainCoveredByWildcard bypass logic on matching domains. #3191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shleeable wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Performance: getTraefikConfig anySitesOnline out of loop / isDomainCoveredByWildcard bypass logic on matching domains. #3191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e4b9b5
Update getTraefikConfig.ts
shleeable May 30, 2026
1f9fc14
Update TraefikConfigManager.ts
shleeable May 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions server/lib/traefik/TraefikConfigManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1197,6 +1197,11 @@ export function isDomainCoveredByWildcard(
): boolean {
for (const [certDomain, state] of lastLocalCertificateState) {
if (state.exists && state.wildcard) {
// If it's an exact match
if (domain === certDomain) {
return true;
}

// If stored as example.com but is wildcard, check subdomains
if (domain.endsWith("." + certDomain)) {
// Check that it's only one level deep (wildcard only covers one level)
Expand Down
26 changes: 11 additions & 15 deletions server/lib/traefik/getTraefikConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,19 +469,17 @@ export async function getTraefikConfig(
};
}

// Check if any sites are online
// THIS IS SO THAT THERE IS SOME IMMEDIATE FEEDBACK
// EVEN IF THE SITES HAVE NOT UPDATED YET FROM THE
// RECEIVE BANDWIDTH ENDPOINT.

// TODO: HOW TO HANDLE ^^^^^^ BETTER
const anySitesOnline = targets.some((target) => target.site.online);

config_output.http.services![serviceName] = {
loadBalancer: {
servers: (() => {
// Check if any sites are online
// THIS IS SO THAT THERE IS SOME IMMEDIATE FEEDBACK
// EVEN IF THE SITES HAVE NOT UPDATED YET FROM THE
// RECEIVE BANDWIDTH ENDPOINT.

// TODO: HOW TO HANDLE ^^^^^^ BETTER
const anySitesOnline = targets.some(
(target) => target.site.online
);

return (
targets
.filter((target) => {
Expand Down Expand Up @@ -602,14 +600,12 @@ export async function getTraefikConfig(

const ppPrefix = config.getRawConfig().traefik.pp_transport_prefix;

// Check if any sites are online
const anySitesOnline = targets.some((target) => target.site.online);

config_output[protocol].services[serviceName] = {
loadBalancer: {
servers: (() => {
// Check if any sites are online
const anySitesOnline = targets.some(
(target) => target.site.online
);

return targets
.filter((target) => {
if (!target.enabled) {
Expand Down
Loading