Skip to content

Add support for quadruple and extended double precision support #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2021

Conversation

awvwgk
Copy link
Member

@awvwgk awvwgk commented Nov 6, 2021

  • Fpm will require preprocessor defines -DWITH_QP={0|1} and -DWITH_XDP={0|1}
  • meson and cmake will attempt to run test programs automatically determine this information
  • not quite pure Fortran anymore since we need a preprocessor
  • support for GCC 5 is lost

Required for fortran-lang/stdlib#494

@awvwgk awvwgk added the enhancement New feature or request label Nov 6, 2021
@awvwgk awvwgk requested a review from milancurcic November 6, 2021 12:39
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2021

Codecov Report

Merging #6 (a50109c) into main (d94d77b) will increase coverage by 1.96%.
The diff coverage is 76.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
+ Coverage   67.13%   69.10%   +1.96%     
==========================================
  Files           2        2              
  Lines         353      479     +126     
  Branches      191      260      +69     
==========================================
+ Hits          237      331      +94     
  Misses         23       23              
- Partials       93      125      +32     
Impacted Files Coverage Δ
src/testdrive.F90 70.57% <76.81%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d94d77b...a50109c. Read the comment docs.

@awvwgk awvwgk force-pushed the precision branch 7 times, most recently from 7050df5 to c958800 Compare November 6, 2021 15:30
- Fpm will require preprocessor defines -DWITH_QP={0|1} and -DWITH_XDP={0|1}
- meson and cmake will attempt to run test programs automatically determine this information
- make driver procedures recursive to allow running the testsuites in strict mode
- provide is_nan implementation for compiler not having IEEE arithmetic support
Copy link
Member

@milancurcic milancurcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for doing this. FWIW I don't understand most of the changes in this PR, but agree with it and trust that it's correct.

@awvwgk awvwgk merged commit 6f56c05 into fortran-lang:main Nov 6, 2021
@awvwgk awvwgk deleted the precision branch November 6, 2021 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants