fix: jumping when aligned at bottom (#69) #211
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #69, by only applying the
deltaX/Y
when the element seems to have moved either viadeltaTop
ordeltaBottom
etc.FixedAAJump.mp4
I also added a debounce skip to
updatePos
, for when the animations finish, as it delayed having accurateoldPos
.This caused elements to be offset when triggering auto-animate shortly after the animations ended.
AASlowUpdatePos.mp4
Ultimately this makes it possible to use auto-animate for building trays/bottom-sheets like this
DynamicBottomSheetWithAutoanimate.mp4