Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-9592: Fix default submit button #593

Merged

Conversation

mikekotikov
Copy link
Contributor

@mikekotikov mikekotikov commented Jan 17, 2025

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9592

Description

What changed?

Added submit button to initial form and subscribed to setDisplay renderer event to update the form definition (fixes submit button addition/removal when switching to Wizard form type and back)

Why have you chosen this solution?

Use this section to justify your choices

Breaking Changes / Backwards Compatibility

Use this section to describe any potentially breaking changes this PR introduces or any effects this PR might have on backwards compatibility

Dependencies

formio/formio.js/pull/5984

How has this PR been tested?

Manually

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@mikekotikov mikekotikov force-pushed the fix/FIO-9592_saved_submit_button_for_forms_and_recources branch from d34066c to b1af695 Compare January 17, 2025 09:28
Copy link
Contributor

@brendanbond brendanbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, but is there a reason that we shouldn't just consolidate this logic into the builder itself? Why should React care about submit buttons? What happens in the builder in angular? etc.

@mikekotikov
Copy link
Contributor Author

This looks fine, but is there a reason that we shouldn't just consolidate this logic into the builder itself? Why should React care about submit buttons? What happens in the builder in angular? etc.

@brendanbond do you mean the initial form? so to make the renderer edit it and add a button?

@brendanbond brendanbond merged commit 50d4bde into master Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants