Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-9590 | FIO-9575: Show api validation errors for form settings block #592

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mikekotikov
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9590

https://formio.atlassian.net/browse/FIO-9575

Description

What changed?

Added catch for api errors regarding form settings and rendered error component to show them to the user.

Why have you chosen this solution?

Use this section to justify your choices

Breaking Changes / Backwards Compatibility

Use this section to describe any potentially breaking changes this PR introduces or any effects this PR might have on backwards compatibility

Dependencies

None

How has this PR been tested?

Manually

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

Copy link
Contributor

@brendanbond brendanbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should discuss this as a team, because I think this is an open question: should the React renderer actually render errors? Or just surface them so that the consumer application can handle them how they wish?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants