Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-9908: fixed an issue where condition does not work properly if 'show' setting is a string #6069

Conversation

TanyaGashtold
Copy link
Contributor

@TanyaGashtold TanyaGashtold commented Mar 27, 2025

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9908

Description

What changed?

If the 'show' setting of conditionals is a string, we need to parse it and convert to boolean so that it works as expected.

Dependencies

formio/core#232
https://github.com/formio/premium/pull/386

How has this PR been tested?

Manually + autotests

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@TanyaGashtold TanyaGashtold changed the title FIO-9908: fixed an issue where condtion does not work properly if 'show' setting is a string FIO-9908: fixed an issue where condition does not work properly if 'show' setting is a string Mar 27, 2025
@brendanbond brendanbond merged commit b439a4d into master Mar 28, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants