Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-9527: Fixed address component with multiple values #5983

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

roma-formio
Copy link
Contributor

@roma-formio roma-formio commented Jan 16, 2025

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9527

Description

Issue: This PR removes the ability to assign the component path property during validation. However, the address component contains a small piece of logic that relies on this property.

Solution: Use this.path instead of this.component.path as the approach with paths has been reworked.

How has this PR been tested?

Unti testing

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@johnformio johnformio merged commit fcd067b into master Jan 16, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants