Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-9524: Fix bad request when fetching nested form #5966

Closed
wants to merge 3 commits into from

Conversation

mikekotikov
Copy link
Contributor

@mikekotikov mikekotikov commented Jan 3, 2025

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9524

Description

What changed?

When esignature module is used, the nested form gets initialized with a Formio from it's build. And it doesn't have a set project url that matches currently open project. So the final link to the nested form is malformed and 400 Bad Request happens.
I've tried adjusting the imports of Formio to point to same Formio instance, but didn't succeed with that approach.
So as another solution I've managed to pass the project URL in the options object and use it if it's present.

Why have you chosen this solution?

Use this section to justify your choices

Breaking Changes / Backwards Compatibility

Use this section to describe any potentially breaking changes this PR introduces or any effects this PR might have on backwards compatibility

Dependencies

ngFormio#741

How has this PR been tested?

Automated test is added

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

Copy link
Contributor

@brendanbond brendanbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So if I understand this correctly, esignature is bundling a version of Formio with itself. Isn't this the fundamental problem? Why does esignature need to bundle Formio, it should depend on it as a peer dependency (or as an external in webpack)

@mikekotikov
Copy link
Contributor Author

So if I understand this correctly, esignature is bundling a version of Formio with itself. Isn't this the fundamental problem? Why does esignature need to bundle Formio, it should depend on it as a peer dependency (or as an external in webpack)

@brendanbond you're right 👍🏼
Rechecked with @johnformio changes with omitting formio deps bundling and the issue is gone. So closing the PRs for this item

@mikekotikov mikekotikov closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants