Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-9418: Fixed the edit grid errors to show the outer error wrapper if any fields in the edit grid are invalid. #5935

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

travist
Copy link
Member

@travist travist commented Dec 4, 2024

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9418

Description

We previously used to show the "wrapper" error around the EditGrid component when a value inside the EditGrid is invalid. This was recently changed to where we only show the error around the component that has the problem. This works fine until that component is "hidden" to where you don't see any visual feedback if your row is invalid. This change ensures that we add the "wrapper" error around the EditGrid when a row error occurs which always gives the user a visual feedback if an EditGrid component is invalid.

Breaking Changes / Backwards Compatibility

This does re-introduce the error "wrapper" around the EditGrid, even if the error in the row is visually seen. Some may see this as "to many" visual indications of an error, but this also goes back to the way it used to work.

Dependencies

None

How has this PR been tested?

Manual

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@TanyaGashtold TanyaGashtold merged commit bb6839b into master Dec 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants