Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-8040: use core utils for evaluation instead of local ones #5535

Closed

Conversation

AlexeyNikipelau
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-8040

Description

Previously, formio.js was using its own util function set for evalutions context. Now it's usng core functions.

Dependencies

formio/core#54

How has this PR been tested?

manually

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

Copy link
Contributor

@brendanbond brendanbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work because @formio/core doesn't expose that path via the "exports" param in its package.json, you can confirm by just running the tests

my vote is to ditch the "exports" field in both @formio/js and @formio/core, it doesn't do much for us (e.g. doesn't tree shake) and just makes it harder to use, if we need formUtil we should just export it from the library

@travist
Copy link
Member

travist commented Apr 23, 2024

I did this here. 0c43678

@travist travist closed this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants