Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-7899: fixed an issue where saveDraft option does not work and added errors handling for the save draft and restore draft functionality #5521

Merged
merged 6 commits into from
Mar 6, 2024

Conversation

TanyaGashtold
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-7899

Description

What changed?

  • call restoreDraft once the form is ready, as restoreDraft requires the formio instance to be attached
  • added errors handling for saveDraft and restoreDraft

How has this PR been tested?

All tests passed locally + added test for my fix

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@HannaKurban HannaKurban merged commit 9126f5c into master Mar 6, 2024
3 checks passed
lane-formio added a commit that referenced this pull request Mar 20, 2024
…ed errors handling for the save draft and restore draft functionality (#5521)

* FIO-7899: fixed an issue where saveDraft option does not work and added errors handling for the save draft and restore draft functionality

* FIO-7899 add yarn.lock

* FIO-7899 point yarn.lock to correct registry

* FIO-7899 Update choices yarn.lock to yarn registry

* FIO-7899 Override all pkg.form.io entries to yarnpkg.com

---------

Co-authored-by: lane-formio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants