Skip to content

FIO-10034: added missed types #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2025

Conversation

KirylDrutsko
Copy link
Contributor

@KirylDrutsko KirylDrutsko commented Apr 24, 2025

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-10034

Description

added missed types requared for proper Premium build

Dependencies

https://github.com/formio/premium/pull/391

How has this PR been tested?

manually

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@@ -96,4 +96,5 @@ export type BaseComponent = {
errors?: Record<string, string>;
truncateMultipleSpaces?: boolean;
serverOverride?: Record<string, any>;
hideColumnByDefault?: boolean;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a BaseComponent setting (in other words, a setting that all components share) or a specific component's setting?

@brendanbond brendanbond merged commit 91aeefe into master May 2, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants