Skip to content

fix: FormDrawer and FormDialog cannot open when set Portal #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+38 −35
Open

fix: FormDrawer and FormDialog cannot open when set Portal #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
927c049
Update portal.tsx
over58 Jul 31, 2025
0c64fc9
Update FormDialog.zh-CN.md
over58 Jul 31, 2025
58473d8
Update FormDrawer.md
over58 Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/components/FormDialog.zh-CN.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,10 +167,10 @@ const schema = {

export default () => {
return (
<FormDialog.Portal>
<FormDialog.Portal id="test2">
<Button
onClick={() => {
const dialog = FormDialog('弹窗表单', () => {
const dialog = FormDialog('弹窗表单', 'test2', () => {
return (
<FormLayout labelCol={6} wrapperCol={10}>
<SchemaField schema={schema} />
Expand Down
67 changes: 35 additions & 32 deletions docs/components/FormDrawer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,39 +171,42 @@ const schema = {

export default () => {
return (
<Button
onClick={() => {
FormDrawer('Pop-up form', () => {
return (
<FormLayout labelCol={6} wrapperCol={10}>
<SchemaField schema={schema} />
<FormDrawer.Extra>
<FormButtonGroup align="right">
<Submit
onSubmit={() => {
return new Promise((resolve) => {
setTimeout(resolve, 1000)
})
}}
>
Submit
</Submit>
<Reset>Reset</Reset>
</FormButtonGroup>
</FormDrawer.Extra>
</FormLayout>
)
})
.open({
initialValues: {
aaa: '123',
},
<>
<FormDrawer.Portal id="form-drawer-portal2" />
<Button
onClick={() => {
FormDrawer('Pop-up form', 'form-drawer-portal2', () => {
return (
<FormLayout labelCol={6} wrapperCol={10}>
<SchemaField schema={schema} />
<FormDrawer.Extra>
<FormButtonGroup align="right">
<Submit
onSubmit={() => {
return new Promise((resolve) => {
setTimeout(resolve, 1000)
})
}}
>
Submit
</Submit>
<Reset>Reset</Reset>
</FormButtonGroup>
</FormDrawer.Extra>
</FormLayout>
)
})
.then(console.log)
}}
>
Click me to open the form
</Button>
.open({
initialValues: {
aaa: '123',
},
})
.then(console.log)
}}
>
Click me to open the form
</Button>
</>
)
}
```
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/__builtins__/portal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export const createPortalProvider = (id: string | symbol) => {
{props.children}
<Observer>
{() => {
if (portalId!) return <></>
if (!portalId) return <></>
const portal = PortalMap.get(portalId)
if (portal) return createPortal(portal, document.body)
return <></>
Expand Down
Loading