Skip to content

Run Molscrub as a Python .EXE file#16

Open
pslacerda wants to merge 2 commits intoforlilab:developfrom
pslacerda:windows.exe
Open

Run Molscrub as a Python .EXE file#16
pslacerda wants to merge 2 commits intoforlilab:developfrom
pslacerda:windows.exe

Conversation

@pslacerda
Copy link
Copy Markdown

Updated setup.py to generate a .EXE file for molscrub.

Some changes were needed and the code were adjusted accordingly.

@diogomart
Copy link
Copy Markdown
Contributor

Thanks! What's the advantage in renaming the file scripts/scrub.py to scripts/main.py?

@pslacerda
Copy link
Copy Markdown
Author

In my case, t's easier to run the program. For instance:

python -m scrubber.main ARG1 ARG ...
# or
$SYS_PREFIX/Scripts/scrub.py.exe ARG1 ARG2 ...

This PR is a follow up of #15. I think that #15 is cooler because do a little refactor, but i'm not sure anymore it's working. This current PR works!

However I'd rather rename the script from scrub.py to molscrub, and the package from scrubber to molscrub. But it isn't a personal project and you all probably have more questions.

Molscrub solves a problem that don't I even thought I had. Very cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants