Conversation
|
The "[Output histogram (--plot) fixed]" commit should fix a couple of problems when trying to plot the histogram:
|
|
Hi Daniel and thank you for your code suggestions. Everything looks OK to me except the "Histogram is not displayed when saved, because function save_scatterplot() closes the figure after saving it, so closing line is commented". As fas as I understand the intended behavior, if you for example have a script that produces multiple plots you might just want to save them all without keeping them open. The user is still able to manually save the figure when it is open. Therefore, the plot.close() should be kept when the "save" option is used. I will clarify in the documentation the intended usage here. Could you also change the PR so it attempts to merge with Develop, and not Release? |
|
perfect then, I hve already switched the base branch to develop. Thank you for looking into it |
|
PR approved |
Flex residues JSON Nonetype error fixed plus bug fix for histogram binning
Catches the None, None returned by
flexible_residues, flexres_atomnames = self.storageman.fetch_flexres_info()
and adapts " flexible_residues, flexres_atomnames " to the expected "[], []"
Would fix #68