Remove the attribute which fixes the app to portrait mode. #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
The app works only in portrait mode before this. There was a flag which was set so that the app never switched to landscape mode even when user rotates the phone.
Probably because originally we were not saving webview's state and then restoring it. This might have caused the webview to reload the app from scratch and not preserve where user was in the app.
Since the state saving and restoring was added some time ago. This now works smoothly(ish) even after we remove that flag which sets it to portrait-only.
One problem that happens is that user is initially greeted with the splash-screen on rotating the device until the webpage loads.
Related Tickets & Documents
#62
Screenshots/Recordings (if there are UI changes)
There are UI changes but the Android screen capture doesn't correctly pickup the orientation change so not posting any. Since there are no UI changes inside the app, it has just started functioning in landscape mode too now.
[optional] What gif best describes this PR or how it makes you feel?