Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: no adapter classes #1382

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
63ce40e
fix(perf): fewer adapter classes
mshanemc Jun 25, 2024
fd40840
refactor: derive metadataWithContent directly from type, not type => …
mshanemc Jun 25, 2024
70cf34c
test: remove invalid test case
mshanemc Jun 25, 2024
3095134
chore: bump core for xnuts
mshanemc Jun 25, 2024
08371d0
wip: clean up existing classes
mshanemc Jun 25, 2024
5b6d0ac
wip: even less classy adapters
mshanemc Jun 27, 2024
2ebc8de
Merge remote-tracking branch 'origin/main' into sm/no-adapter-classes
mshanemc Jun 30, 2024
f69a337
docs: typo
mshanemc Jul 15, 2024
e4414d0
refactor: no adapter classes
mshanemc Jul 15, 2024
018257d
Merge remote-tracking branch 'origin/main' into sm/no-adapter-classes
mshanemc Jul 26, 2024
496a493
refactor: organize adapter shared types
mshanemc Jul 26, 2024
d542496
chore: rename deb bundle detector
mshanemc Jul 30, 2024
3b93cc4
fix: get deb to resolve properly
mshanemc Jul 31, 2024
61b779d
chore: stash wip
mshanemc Jul 31, 2024
e0b80bb
test: set the contents for a forceIgnore. handy for ut
mshanemc Aug 1, 2024
5a0ff3c
test: passing ut and snapshot
mshanemc Aug 1, 2024
1727cd3
Merge remote-tracking branch 'origin/main' into sm/no-adapter-classes
mshanemc Aug 1, 2024
fffaea9
fix: allow more undefined from adapters
mshanemc Aug 1, 2024
42eb6d7
refactor: shared posixify fn for windows ut
mshanemc Aug 1, 2024
6e91e38
docs: handbook update
mshanemc Aug 1, 2024
0f149cc
docs: remove wip readme for adapters
mshanemc Aug 1, 2024
78ba78c
test: windows ut need posix paths in forceignore contents
mshanemc Aug 2, 2024
1ff3f66
test: ut for forceignore injection
mshanemc Aug 2, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: remove invalid test case
mshanemc committed Jun 25, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 70cf34ca4a7987aab605ef093eabdda345434771
15 changes: 1 addition & 14 deletions test/resolve/adapters/defaultSourceAdapter.test.ts
Original file line number Diff line number Diff line change
@@ -12,7 +12,7 @@ import { META_XML_SUFFIX } from '../../../src/common';

describe('DefaultSourceAdapter', () => {
it('should return a SourceComponent when given a metadata xml file', () => {
const type = registry.types.apexclass;
const type = registry.types.eventdelivery;
const path = join('path', 'to', type.directoryName, `My_Test.${type.suffix}${META_XML_SUFFIX}`);
const adapter = new DefaultSourceAdapter(type);
expect(adapter.getComponent(path)).to.deep.equal(
@@ -23,17 +23,4 @@ describe('DefaultSourceAdapter', () => {
})
);
});

it('should return a SourceComponent when given a content-only metadata file', () => {
const type = registry.types.apexclass;
const path = join('path', 'to', type.directoryName, `My_Test.${type.suffix}`);
const adapter = new DefaultSourceAdapter(type);
expect(adapter.getComponent(path)).to.deep.equal(
new SourceComponent({
name: 'My_Test',
type,
xml: path,
})
);
});
});