Make computeType an input parameter #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! It looks like @ppandit-sfdc is an internal user so signing the CLA is not required. However, we need to confirm this. |
sbyrne-sf
requested changes
Aug 20, 2025
src/datacustomcode/cli.py
Outdated
| @click.option("--version", default="0.0.1") | ||
| @click.option("--description", default="Custom Data Transform Code") | ||
| def deploy(path: str, name: str, version: str, description: str): | ||
| @click.option("--compute-type", default="CPU_2XL") |
There was a problem hiding this comment.
Please add documentation here using help="" to describe the options in the CLI directly.
There was a problem hiding this comment.
Not a huge deal, but something shorter like "cpu-size" or just "size" is nicer to type.
There was a problem hiding this comment.
Ill add the help part, and will also change the arg to cpu-size 👍
sbyrne-sf
approved these changes
Aug 20, 2025
joroscoSF
pushed a commit
that referenced
this pull request
Aug 25, 2025
* Add argument for computeType
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.