Skip to content

[ENH] - Update Modes management to use sub-object attributes rather than inheritance #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Mar 24, 2025

Conversation

TomDonoghue
Copy link
Member

@TomDonoghue TomDonoghue commented Mar 22, 2025

Interim update to set objects to use sub-objects as attributes, rather than inheriting everything into singular objects.

Merged into sub-branch for checking there before integrating to main.

@fooof-tools fooof-tools deleted a comment from codecov bot Mar 22, 2025
@fooof-tools fooof-tools deleted a comment from codecov bot Mar 22, 2025
@fooof-tools fooof-tools deleted a comment from codecov bot Mar 23, 2025
@fooof-tools fooof-tools deleted a comment from codecov bot Mar 23, 2025
@fooof-tools fooof-tools deleted a comment from codecov bot Mar 24, 2025
Copy link

codecov bot commented Mar 24, 2025

Codecov Report

Attention: Patch coverage is 97.85553% with 19 lines in your changes missing coverage. Please review.

Project coverage is 97.23%. Comparing base (9f5de2e) to head (32cf001).
Report is 29 commits behind head on modes.

Files with missing lines Patch % Lines
specparam/objs/utils.py 0.00% 4 Missing ⚠️
specparam/modes/modes.py 83.33% 3 Missing ⚠️
specparam/algorithms/spectral_fit.py 97.50% 1 Missing ⚠️
specparam/measures/gof.py 0.00% 1 Missing ⚠️
specparam/models/event.py 93.33% 1 Missing ⚠️
specparam/models/group.py 85.71% 1 Missing ⚠️
specparam/models/time.py 88.88% 1 Missing ⚠️
specparam/modes/mode.py 0.00% 1 Missing ⚠️
specparam/objs/base.py 99.36% 1 Missing ⚠️
specparam/objs/metrics.py 97.67% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##            modes     #354      +/-   ##
==========================================
- Coverage   97.24%   97.23%   -0.01%     
==========================================
  Files         135      141       +6     
  Lines        5728     5867     +139     
==========================================
+ Hits         5570     5705     +135     
- Misses        158      162       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TomDonoghue TomDonoghue merged commit 66ff9d5 into modes Mar 24, 2025
9 checks passed
@TomDonoghue TomDonoghue deleted the objb branch March 24, 2025 16:16
@TomDonoghue TomDonoghue changed the title [WIP] - Update Modes management [ENH] - Update Modes management to use sub-object attributes rather than inheritance Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant