-
-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dropdown): direction calculation #2975
base: develop
Are you sure you want to change the base?
Conversation
fixes menu calculation while infering direction
Could you please provide a jsfiddle to reproduce the issue and confirm your fix? Removing the hidden class before animating may has other visual impacts which needs testing |
will provide a reproducible case later, in the mean time here is the config used:
may be could be a racing issue between parsing a relatively big json object and / or the async callback
in can.openDownward() just below the calculations declaration. |
Description
fixes menu calculation while inferring direction
when using the api settings, after the second request the menu list element has the
display: hidden !important;
css prop, producing a zero inner height of the menu during the direction calculation.