Skip to content

Conversation

@elsenhans
Copy link
Contributor

https://folio-org.atlassian.net/browse/UIOR-1513

Purpose

Fix permission error for edit custom-fields.

Approach

Replace subPermission
mod-settings.global.write.ui-orders.custom-fields.edit by
mod-settings.global.write.ui-orders.custom-fields.manage
since these are the custom fields permission names for read and write:

      {
        "permissionName": "mod-settings.global.read.ui-orders.custom-fields.manage",
        "displayName": "Settings (Orders): Read the settings in the 'custom fields' section",
        "visible": false
      },
      {
        "permissionName": "mod-settings.global.write.ui-orders.custom-fields.manage",
        "displayName": "Settings (Orders): Write the settings in the 'custom fields' section",
        "visible": false
      },

Screenshots

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@elsenhans elsenhans requested a review from a team February 10, 2026 14:07
@github-actions
Copy link

Jest Unit Test Results

    1 files  ±0    295 suites  ±0   7m 24s ⏱️ -7s
1 002 tests ±0    994 ✅ ±0  8 💤 ±0  0 ❌ ±0 
1 010 runs  ±0  1 002 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit 5075597. ± Comparison against base commit 9bde592.

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant