Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIMPROF-98 Allow users to reorder their application links in that appear in the main nav. #238

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

JohnC-80
Copy link

@JohnC-80 JohnC-80 commented Jan 27, 2025

UIMPROF-98

Purpose

Users want control of the order in which their apps appear in their main navigation so they can prevent having to open the Apps dropdown every time to reach a particular app.

Approach

This PR makes use of a new context exposed in stripes-core via a hook - useAppOrderContext(). It provides the the existing value for the list order (if any) as well as a mechanism for updating the preference.

The UI behavior includes 'drag n drop' interaction. For this, it makes use of a new-to-FOLIO library called dnd-kit. Use of this library is intended to replace our existing react-beautiful-dnd usage. It provides a deep level of customization - including translation strings for its included screen reader announcements. This PR implements a special coordinatesGetter that is used with keyboard interaction of the list to 'step' keyboard-active items through the list using the up/down arrow keys.

TODOS and Open Questions

  • Complete translations.
  • Tests!

Copy link

github-actions bot commented Jan 27, 2025

Jest Unit Test Statistics

36 tests  +13   36 ✔️ +13   55s ⏱️ +21s
  5 suites +  3     0 💤 ±  0 
  1 files   ±  0     0 ±  0 

Results for commit 4bff8d6. ± Comparison against base commit d3ef76e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 27, 2025

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 4bff8d6. ± Comparison against base commit d3ef76e.

♻️ This comment has been updated with latest results.

@JohnC-80 JohnC-80 requested a review from zburke January 27, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant