Skip to content

UIIN-3595: Show label for type in holdings version history#2967

Open
elsenhans wants to merge 3 commits intomasterfrom
UIIN-3595-show-labe-for-type-in-holdings-version-history
Open

UIIN-3595: Show label for type in holdings version history#2967
elsenhans wants to merge 3 commits intomasterfrom
UIIN-3595-show-labe-for-type-in-holdings-version-history

Conversation

@elsenhans
Copy link
Contributor

https://folio-org.atlassian.net/browse/UIIN-3595

Purpose

In the version history of Holdings is shown the ID instead of the label for type of additionalCallNumbers .

Steps to Reproduce:

  • Log into FOLIO Snapshot
  • Open the Inventory App
  • Select an Instance (create one if none is available)
  • Go to the Holdings of this Instance (create one if none is available)
  • Click on “View Holdings”
  • Click on “Actions” > “Edit”
  • Click on “Add additional call number”
  • Select a Call number type and enter some data in the other fields for the additional call number
  • Click on “Save & close”
  • Click on the Version History symbol
  • Click on “Changed” to open the detail view for your change
  • Check what is written next to “Additional call number type:”

Current Results:
The call number type is not written out correctly but is represented by a code consisting of numbers and letters—e.g. “cd70562c-dd0b-42f6-aa80-ce803d24d4a1”.

Expected Results:
The signature type should be displayed with the correct name—e.g. “Title”, “Shelved separately”.

On the item level, the call number type of the additional call number is displayed correctly in the version history.

Approach

Add formatter for typeId

Refs

https://folio-org.atlassian.net/browse/UIIN-3559
https://folio-org.atlassian.net/browse/UIIN-3540
PR: #2954

Screenshots

Showing type ID:
image

Showing type label:
image

@elsenhans elsenhans requested a review from a team February 3, 2026 13:25
@github-actions
Copy link

github-actions bot commented Feb 3, 2026

Jest Unit Test Results

    1 files  ±0    321 suites  ±0   10m 35s ⏱️ +13s
1 431 tests ±0  1 412 ✅ ±0  19 💤 ±0  0 ❌ ±0 
1 445 runs  ±0  1 426 ✅ ±0  19 💤 ±0  0 ❌ ±0 

Results for commit 1595677. ± Comparison against base commit 5f81181.

♻️ This comment has been updated with latest results.

@elsenhans elsenhans requested a review from a team February 5, 2026 11:47
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 6, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant