UIIN-3595: Show label for type in holdings version history#2967
Open
UIIN-3595: Show label for type in holdings version history#2967
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


https://folio-org.atlassian.net/browse/UIIN-3595
Purpose
In the version history of Holdings is shown the ID instead of the label for
typeofadditionalCallNumbers.Steps to Reproduce:
Current Results:
The call number type is not written out correctly but is represented by a code consisting of numbers and letters—e.g. “cd70562c-dd0b-42f6-aa80-ce803d24d4a1”.
Expected Results:
The signature type should be displayed with the correct name—e.g. “Title”, “Shelved separately”.
On the item level, the call number type of the additional call number is displayed correctly in the version history.
Approach
Add formatter for
typeIdRefs
https://folio-org.atlassian.net/browse/UIIN-3559
https://folio-org.atlassian.net/browse/UIIN-3540
PR: #2954
Screenshots
Showing type ID:

Showing type label:
