[UID-159] Better handle RTR callback; handle new token expiration format #438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncovercash
commented
Oct 10, 2024
Comment on lines
-15
to
-25
| // why WHY copy this string here instead of importing it from stripes-core? | ||
| // | ||
| // RTR_FORCE_REFRESH_EVENT will be present in stripes-core 10.2.0 (stripes | ||
| // 9.2.0). Importing it would force the stripes peer depedency to bump from | ||
| // ^9.1.0 to ^9.2.0.If we copy the string instead of importing it, we can | ||
| // remain compatible with 9.1.0. | ||
| // | ||
| // OK, compatibility is nice. But it's still gross, right? Yep, super gross. | ||
| // Aren't you nauseated? Yes, yes I am. 🤢🧼🛁 | ||
| const RTR_FORCE_REFRESH_EVENT = '@folio/stripes/core::RTRForceRefresh'; | ||
|
|
Member
Author
There was a problem hiding this comment.
Now that ui-developer 9.0.0 is out, we should be safe to do 9.2.0 for R release.
ncovercash
commented
Oct 10, 2024
Comment on lines
+22
to
+23
| atExpires: te.atExpires ?? te.accessTokenExpiration ?? -1, | ||
| rtExpires: te.rtExpires ?? te.refreshTokenExpiration ?? -1, |
Member
Author
There was a problem hiding this comment.
safely handles old and new style
bvsharp
approved these changes
Oct 10, 2024
ncovercash
commented
Oct 10, 2024
| </Button> | ||
|
|
||
| <Form | ||
| {/* <Form |
Member
Author
There was a problem hiding this comment.
this form currently doesn't configure anything, due to that being pulled from STCOR-888, so let's hide it.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.