Skip to content

Conversation

@Dmitriy-Litvinenko
Copy link
Contributor

@Dmitriy-Litvinenko Dmitriy-Litvinenko commented Dec 2, 2025

Purpose

Migrate config values from mod-configuration

Approach

Migrate config values from mod-configuration to mod-circulation.
This changes should be merged together with corresponding BE changed.

Refs

https://issues.folio.org/browse/UICHKIN-476

@github-actions
Copy link

github-actions bot commented Dec 2, 2025

Jest Unit Test Results

  1 files  ±0   19 suites  ±0   17s ⏱️ -1s
314 tests  - 1  314 ✅  - 1  0 💤 ±0  0 ❌ ±0 
318 runs   - 1  318 ✅  - 1  0 💤 ±0  0 ❌ ±0 

Results for commit e0234b9. ± Comparison against base commit 59b3505.

This pull request removes 3 and adds 2 tests. Note that renamed tests count towards both.
getCheckinSettings receives an object given JSON data in av[0].value ‑ getCheckinSettings receives an object given JSON data in av[0].value
getCheckinSettings returns undefined given an empty array ‑ getCheckinSettings returns undefined given an empty array
getCheckinSettings returns {} given non-JSON data ‑ getCheckinSettings returns {} given non-JSON data
getCheckinSettings should returns undefined for empty array ‑ getCheckinSettings should returns undefined for empty array
getCheckinSettings should returns value of first element (object) ‑ getCheckinSettings should returns value of first element (object)

♻️ This comment has been updated with latest results.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 3, 2025

@Dmitriy-Litvinenko Dmitriy-Litvinenko requested a review from a team December 3, 2025 13:41
@Dmitriy-Litvinenko Dmitriy-Litvinenko requested a review from a team December 5, 2025 11:45
@sonarqubecloud
Copy link

@Dmitriy-Litvinenko Dmitriy-Litvinenko merged commit c9e4373 into master Jan 29, 2026
15 checks passed
@Dmitriy-Litvinenko Dmitriy-Litvinenko deleted the UICHKIN-476 branch January 29, 2026 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants