Skip to content

Require the TC Module Eval tool (April 2026) #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
maccabeelevine wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Require the TC Module Eval tool (April 2026) #110

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fcd9853
Require the TC Module Eval tool
maccabeelevine Oct 9, 2025
76a94c2
Merge branch 'master' into license-eval-require-tool
maccabeelevine Nov 13, 2025
b891ec0
Add back missing note from CC
maccabeelevine Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions MODULE_ACCEPTANCE_CRITERIA.MD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,15 +59,10 @@ Use these conventions to indicate the status of each criterion.
* [ ] Uses Apache 2.0 license (2)
* [ ] Module build MUST produce a valid module descriptor (3, 5)
* _This is not applicable to libraries_
* [ ] Inclusion of third party dependencies complies with [ASF 3rd Party License Policy](https://apache.org/legal/resolved.html) (2)
* Uses README for [Category B Appropriately Labelled Condition](https://apache.org/legal/resolved.html#appropriately-labelled-condition)
* LGPL consideration:
* org.z3950.zing:cql-java is allowed if appropriately labelled, even if it is LGPL-2.1-only
* org.marc4j:marc4j is allowed if appropriately labelled, even if it is LGPL-2.1-or-later
* org.hibernate.* is allowed if appropriately labelled, even if it is LGPL-2.1-or-later
* By [request of the Community Council](https://folio-org.atlassian.net/wiki/spaces/CC/pages/1243348996/2025-09-26+Community+Council+Meeting+Minutes+at+WOLFcon), and until that request changes, no additional LGPL-licensed dependencies will be allowed.
* [ ] Inclusion of third party dependencies complies with [ASF 3rd Party License Policy](https://apache.org/legal/resolved.html), as defined and reported by the [FOLIO Module Evaluator](https://github.com/folio-org/tc-module-eval) tool (2)
Copy link
Member Author

@maccabeelevine maccabeelevine Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be language in here somewhere (maybe a sub-bullet) that the tool itself is only required for languages that the tool supports. I.e. Golang folio-org/tc-module-eval#13

* GitHub Actions automated evaluation result page shows a passing evaluation.
* _note: See [license-categories.json](https://github.com/folio-org/tc-module-eval/blob/master/config/license-categories.json) for licenses which are allowed (Category A), prohibited (Category X), and allowed when [appropriately labelled in the module's README](https://apache.org/legal/resolved.html#appropriately-labelled-condition) (Category B-WCL). See [special-exceptions.json](https://github.com/folio-org/tc-module-eval/blob/master/config/special-exceptions.json) for permitted exceptions. By [request of the Community Council](https://folio-org.atlassian.net/wiki/spaces/CC/pages/1243348996/2025-09-26+Community+Council+Meeting+Minutes+at+WOLFcon), and until that request changes, no additional LGPL-licensed dependencies will be allowed._
* _note: If a library declares multiple licenses in its pom.xml, [only one of them needs to comply](https://maven.apache.org/ref/3.9.11/maven-model/maven.html#project)._ (This applies only to Maven. For other package managers, closer evaluation is needed.)
* _note: The [FOLIO Module Evaluator](https://github.com/folio-org/tc-module-eval) tool is optionally available to evaluate this criterion for Java modules (built with Maven) and for front-end modules. TC expects to [require its use](https://github.com/folio-org/tech-council/pull/110) in the module evaluation process after a trial period._
* _note: [More information about this criterion](https://github.com/folio-org/tech-council/blob/master/criteria/THIRD_PARTY_DEPENDENCIES.MD)_
* [ ] Installation documentation is included (11)
* -_note: read more at https://github.com/folio-org/mod-search/blob/master/README.md_
Expand Down