Remove no_cleanup input from module evaluation workflow #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify the workflow by removing the custom output directory feature. The output directory is now hardcoded to 'reports' as the default location for all evaluation reports. Changes: - Removed custom_output_dir input parameter from workflow_dispatch.inputs - Removed output directory normalization logic and hardcoded to 'reports' - Removed echo statement showing custom output directory - Updated output directory variable reference from normalized_output_dir to output_dir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose: Simplify the GitHub Actions workflow by removing optional input parameters that constrain the default behavior. Users no longer need these customization options, and the workflow should use standard defaults.
Approach:
no_cleanupinput parameter, along with its conditional logic and artifact upload stepcustom_output_dirinput parameter and hardcoded the output directory toreportsnormalized_output_dirtooutput_dirThe workflow now always uses:
reportsThis reduces workflow complexity and storage overhead while maintaining all core evaluation functionality.