[STRIPES-971] Add missing timepicker props #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncovercash
commented
Mar 25, 2025
| export interface TimepickerProps extends AriaAttributes { | ||
| export interface TimepickerProps | ||
| extends AriaAttributes, | ||
| Omit<TextFieldProps<string>, 'inputRef' | 'onChange'> { |
Member
Author
There was a problem hiding this comment.
inputRef and onChange conflict with our definitions below (and we yank them out of what gets spread to TextField), so we don't want to include those here
Member
There was a problem hiding this comment.
This is helpful commentary, @ncovercash . Maybe it belongs as a comment in the source rather than just a comment on the PR?
|
bvsharp
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.