Skip to content

Conversation

@BogdanDenis
Copy link
Contributor

Description

Context: With the Trillium release, Language & locale settings were moved from mod-configuration to the /locale API of mod-settings. These settings are tenant level (a user can also set user preference for language at some other API).

  • Front-end modules that use these tenant settings need to call the /locale endpoint to get these settings.
  • Update required interfaces and required permissions from mod-configuration to mod-settings.
  • If this work is not completed in Trillium then any workflows using locale settings will not work as expected.

Also this work is required for mod-configuration deprecation.

Approach

  • Fetch tenant locale settings from /locale API.
  • Removed calls to fetch tenant locale settings from /settings/entries and /configurations/entries
  • Removed calls to fetch user locale settings from /configurations/entries
  • User locale settings are now fetched from /settings/entries

Issues

STCOR-1027

@github-actions
Copy link

Bigtest Unit Test Results

150 tests  ±0   149 ✅ ±0   6s ⏱️ ±0s
  1 suites ±0     1 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit bc68bc7. ± Comparison against base commit cbf24e4.

This pull request removes 152 and adds 150 tests. Note that renamed tests count towards both.
      equal to check email label in english translation
      equal to check email precautions label in english translation
      equal to sent email precautions label in english translation
Chrome_143_0_0_0_(Linux_x86_64).AppIcon Passing a string to the tag-prop ‑ AppIcon Passing a string to the tag-prop Should render an AppIcon with a HTML tag of "div"
Chrome_143_0_0_0_(Linux_x86_64).AppIcon Passing a string using the children-prop ‑ AppIcon Passing a string using the children-prop Should render an AppIcon with a label
Chrome_143_0_0_0_(Linux_x86_64).AppIcon Rendering an AppIcon using Stripes-context ‑ AppIcon Rendering an AppIcon using Stripes-context Should render an <img>
Chrome_143_0_0_0_(Linux_x86_64).AppIcon Rendering an AppIcon using Stripes-context ‑ AppIcon Rendering an AppIcon using Stripes-context Should render an img with an alt-attribute
Chrome_143_0_0_0_(Linux_x86_64).AppIcon Rendering an AppIcon using an icon-object ‑ AppIcon Rendering an AppIcon using an icon-object Should render an <img>
Chrome_143_0_0_0_(Linux_x86_64).AppIcon Rendering an AppIcon using an icon-object ‑ AppIcon Rendering an AppIcon using an icon-object Should render an img with an alt-attribute
Chrome_143_0_0_0_(Linux_x86_64).AppIcon Rendering an AppIcon using an icon-object ‑ AppIcon Rendering an AppIcon using an icon-object Should render with a className of "My className"
…
Chrome_144_0_0_0_(Linux_x86_64).AppIcon Passing a string to the tag-prop ‑ AppIcon Passing a string to the tag-prop Should render an AppIcon with a HTML tag of "div"
Chrome_144_0_0_0_(Linux_x86_64).AppIcon Passing a string using the children-prop ‑ AppIcon Passing a string using the children-prop Should render an AppIcon with a label
Chrome_144_0_0_0_(Linux_x86_64).AppIcon Rendering an AppIcon using Stripes-context ‑ AppIcon Rendering an AppIcon using Stripes-context Should render an <img>
Chrome_144_0_0_0_(Linux_x86_64).AppIcon Rendering an AppIcon using Stripes-context ‑ AppIcon Rendering an AppIcon using Stripes-context Should render an img with an alt-attribute
Chrome_144_0_0_0_(Linux_x86_64).AppIcon Rendering an AppIcon using an icon-object ‑ AppIcon Rendering an AppIcon using an icon-object Should render an <img>
Chrome_144_0_0_0_(Linux_x86_64).AppIcon Rendering an AppIcon using an icon-object ‑ AppIcon Rendering an AppIcon using an icon-object Should render an img with an alt-attribute
Chrome_144_0_0_0_(Linux_x86_64).AppIcon Rendering an AppIcon using an icon-object ‑ AppIcon Rendering an AppIcon using an icon-object Should render with a className of "My className"
Chrome_144_0_0_0_(Linux_x86_64).AppIcon Size tests Passing a size of "large" ‑ AppIcon Size tests Passing a size of "large" Should render an icon into a large-sized container
Chrome_144_0_0_0_(Linux_x86_64).AppIcon Size tests Passing a size of "medium" ‑ AppIcon Size tests Passing a size of "medium" Should render an icon into a medium-sized container
Chrome_144_0_0_0_(Linux_x86_64).AppIcon Size tests Passing a size of "small" ‑ AppIcon Size tests Passing a size of "small" Should render an icon into a small-sized container
…
This pull request removes 1 skipped test and adds 1 skipped test. Note that renamed tests count towards both.
Chrome_143_0_0_0_(Linux_x86_64).PasswordValidationField with an invalid password ‑ PasswordValidationField with an invalid password shows a validation error
Chrome_144_0_0_0_(Linux_x86_64).PasswordValidationField with an invalid password ‑ PasswordValidationField with an invalid password shows a validation error

@github-actions
Copy link

Jest Unit Test Results

  1 files  ±0   83 suites  ±0   1m 42s ⏱️ +2s
498 tests  - 7  495 ✅  - 10  0 💤 ±0  3 ❌ +3 
504 runs   - 7  501 ✅  - 10  0 💤 ±0  3 ❌ +3 

For more details on these failures, see this check.

Results for commit bc68bc7. ± Comparison against base commit cbf24e4.

This pull request removes 9 and adds 2 tests. Note that renamed tests count towards both.
getLocale dispatches setTimezone, setCurrency ‑ getLocale dispatches setTimezone, setCurrency
getUserLocale dispatches setTimezone, setCurrency ‑ getUserLocale dispatches setTimezone, setCurrency
loadResources when there are permissions to read mod-settings and mod-configuration when the user and tenant locale settings are present in mod-settings should fetch the tenant and user locale settings from mod-settings ‑ loadResources when there are permissions to read mod-settings and mod-configuration when the user and tenant locale settings are present in mod-settings should fetch the tenant and user locale settings from mod-settings
loadResources when there are permissions to read mod-settings and mod-configuration when the user or tenant locale settings are not present in mod-settings should apply locale settings from mod-configuration ‑ loadResources when there are permissions to read mod-settings and mod-configuration when the user or tenant locale settings are not present in mod-settings should apply locale settings from mod-configuration
loadResources when there are permissions to read mod-settings and mod-configuration when the user or tenant locale settings are not present in mod-settings should fetch the tenant and user locale settings from mod-settings and mod-configuration ‑ loadResources when there are permissions to read mod-settings and mod-configuration when the user or tenant locale settings are not present in mod-settings should fetch the tenant and user locale settings from mod-settings and mod-configuration
loadResources when there are permissions to read mod-settings and mod-configuration when the user or tenant locale settings are not present in mod-settings should retrieve tenant-locale, user-locale, plugins, and bindings from configurations ‑ loadResources when there are permissions to read mod-settings and mod-configuration when the user or tenant locale settings are not present in mod-settings should retrieve tenant-locale, user-locale, plugins, and bindings from configurations
loadResources when there is permission to only read mod-configuration should apply locale settings ‑ loadResources when there is permission to only read mod-configuration should apply locale settings
loadResources when there is permission to only read mod-configuration should fetch the tenant and user locale settings from mod-configuration ‑ loadResources when there is permission to only read mod-configuration should fetch the tenant and user locale settings from mod-configuration
loadResources when there is permission to only read mod-configuration should retrieve tenant-locale, user-locale, plugins, and bindings from configurations ‑ loadResources when there is permission to only read mod-configuration should retrieve tenant-locale, user-locale, plugins, and bindings from configurations
loadResources when there are permissions to read mod-settings and mod-configuration when the user and tenant locale settings are present in mod-settings should fetch the tenant and user locale settings from mod-settings locale API ‑ loadResources when there are permissions to read mod-settings and mod-configuration when the user and tenant locale settings are present in mod-settings should fetch the tenant and user locale settings from mod-settings locale API
loadResources when there is permission to only read mod-configuration should retrieve plugins and bindings from configurations ‑ loadResources when there is permission to only read mod-configuration should retrieve plugins and bindings from configurations

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
52.2% Coverage on New Code (required ≥ 80%)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants