Skip to content

Button to explicitly reset / remove QSO table filters #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kyleboyle
Copy link

In my time working with this project I've seen several support issues relating to not knowing that QSO table filters are active and limiting the QSOs being displayed. This is an attempt to make working with filters easier. The 2 main changes are:

  1. active filter is now bold text (with green) instead of normal font weight
  2. There is a new reset button which gets enabled whenever the filter is active.
Kapture.2025-05-18.at.16.57.05.webm

NOTE: If my icon theme changes get accepted, I would like to add an icon to the reset button only when active.

@aa5sh
Copy link

aa5sh commented May 18, 2025

I like this. I also think it is a good idea since it seems to come up.

@foldynl
Copy link
Owner

foldynl commented May 20, 2025

I agree that this is a problem we need to solve. However, I don't think we should add a reset button. It wouldn't solve the issue and would just take up space in the GUI.

It seems that even the green color didn't help, so I don't think bold text would be the right solution. Unfortunately, the same problem exists in the DXC Window, where you can't recognize whether the filter is on or off. I've analyzed issues myself many times just because the DXC filter was active.

I'll get back to the issue with Logbook filter. What do you think of this modification: a red frame around the active option? It doesn't solve the issue in the DXC widget, but it could improve the Log widget.

image

@kyleboyle
Copy link
Author

kyleboyle commented May 20, 2025

Yeah that works too... I just think something more obvious should be displayed. I added the reset filter to make it easier to clear if there are multiple filters active and the user wants to go back to nothing filtered. I don't think I agree with the point about taking up gui space, is it currently unused empty space. But I also don't really use the filters much so you'd know better if users have use cases for using multiple filter values at the same time.

@kyleboyle kyleboyle closed this Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants