Merged
Conversation
By default, Spring GraphQL just gives INTERNAL_ERROR with a UUID, but an entity-not-found that reaches the top level is almost certainly due to a bad request param. E.g., unknown recipe id. So let that "leak" back out, so the client knows it's their fault.
Spring's @PreAuthorize happen after binding parameters, so with errorOnInvalidType=true on @AuthenticationPrincipal, an anonymous user who fails the pre-auth test gets a class cast exception, instead of unauthorized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, Spring GraphQL just gives INTERNAL_ERROR with a UUID, but
an entity-not-found that reaches the top level is almost certainly due
to a bad request param. E.g., unknown recipe id. So let that "leak" back
out, so the client knows it's their fault.
Also fix a couple similar issues with anonymous requests yielding INTERNAL_ERROR instead of UNAUTHORIZED, from @currentuser setting errorOnInvalidType=true